Reo-LEI commented on a change in pull request #2898:
URL: https://github.com/apache/iceberg/pull/2898#discussion_r780929212
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java
##########
@@ -84,36 +84,63 @@
private final FileFormat format;
private final int parallelism;
private final boolean partitioned;
+ private final String distributionMode;
private StreamExecutionEnvironment env;
private TestTableLoader tableLoader;
- @Parameterized.Parameters(name = "FileFormat = {0}, Parallelism = {1},
Partitioned={2}")
+ @Parameterized.Parameters(name = "FileFormat = {0}, Parallelism = {1},
Partitioned={2}, Distribution={3}")
public static Object[][] parameters() {
return new Object[][] {
- new Object[] {"avro", 1, true},
- new Object[] {"avro", 1, false},
- new Object[] {"avro", 2, true},
- new Object[] {"avro", 2, false},
- new Object[] {"orc", 1, true},
- new Object[] {"orc", 1, false},
- new Object[] {"orc", 2, true},
- new Object[] {"orc", 2, false},
- new Object[] {"parquet", 1, true},
- new Object[] {"parquet", 1, false},
- new Object[] {"parquet", 2, true},
- new Object[] {"parquet", 2, false}
+ new Object[] {"avro", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"avro", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"avro", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"avro", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"orc", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"orc", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"orc", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"orc", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"parquet", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"parquet", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"parquet", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+ new Object[] {"parquet", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_NONE},
+
+ new Object[] {"avro", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"avro", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"avro", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"avro", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"orc", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"orc", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"orc", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"orc", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"parquet", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"parquet", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"parquet", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+ new Object[] {"parquet", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_HASH},
+
+ new Object[] {"avro", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"avro", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"avro", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"avro", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"orc", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"orc", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"orc", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"orc", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"parquet", 1, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"parquet", 1, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"parquet", 4, true,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE},
+ new Object[] {"parquet", 4, false,
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE}
Review comment:
I think that is ok, becasue distribution modes are only related to
parallelism and partition. I have remove the unnecessary test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
