pvary commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r781991103
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -233,8 +253,8 @@ private void setupMetastoreDB(String dbURL) throws
SQLException, IOException {
}
}
- private String getDerbyPath() {
- File metastoreDB = new File(hiveLocalDir, "metastore_db");
+ private static String getDerbyPath() {
Review comment:
nit: If the `HIVE_LOCAL_DIR` is static, we might get nicer code if we
create a static `DERBY_PATH` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
