jun-he commented on a change in pull request #3875:
URL: https://github.com/apache/iceberg/pull/3875#discussion_r782418646



##########
File path: python_legacy/iceberg/api/expressions/expression_parser.py
##########
@@ -126,6 +126,15 @@ def get_expr_tree(tokens):
                  binary_tuples]}
 
 
+def handle_str_expr(node):
+    if node.startswith("'") and node.endswith("'"):

Review comment:
       Will it handle some complicated cases, e.g. `'foo\'bar\'' case as well?
   wondering if we can use some functions in pyparsing quotedString to solve it?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to