pvary commented on pull request #3879: URL: https://github.com/apache/iceberg/pull/3879#issuecomment-1011892072
Since it is `Hadoop`FileIo, I think it is "natural" to expect it to implement `org.apache.hadoop.conf.Configurable`. That would mean that we would want to keep `getConf()`. OTOH in Iceberg `conf()` is the way to access attributes. I would vote for keeping both, but a comment might be useful to encourage the usage of the `conf()` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
