jackye1995 opened a new issue #3895: URL: https://github.com/apache/iceberg/issues/3895
based on https://github.com/apache/iceberg/pull/3104#discussion_r780844208 I did not have a good way to distinguish what exception to use for what case, the definition provided by Ryan was clear. I think we should add that in the javadoc of `ValidationException` class about when to use it and when to use `Preconditions` to throw illegal argument exception. This will give more clarity to both implementer and reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
