szehon-ho commented on a change in pull request #3872:
URL: https://github.com/apache/iceberg/pull/3872#discussion_r785059817



##########
File path: 
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -86,6 +87,8 @@
     }
   }, DataTypes.StringType);
 
+  private static final ExecutorService DEFAULT_DELETE_EXECUTOR_SERVICE = null;

Review comment:
       Not sure I see a huge point to this variable (feel like a comment could 
have sufficed), but I guess it's there in the ExpireSnapshot version, so no 
matter :)
   
   I guess the explicit assumption is that Tasks execute without a service, 
executes the task on a single thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to