humengyu2012 removed a comment on pull request #3912: URL: https://github.com/apache/iceberg/pull/3912#issuecomment-1014947194
I have tried to remove `id++`, but it will change the id generation order, and lead to some test fail. Because the method `convertType()` will call method `convert()` recursively when struct type occurs, id will be added. So I think it shouldn't be changed in this pr. I can do this in the next pr if we need it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
