kbendick commented on a change in pull request #3915:
URL: https://github.com/apache/iceberg/pull/3915#discussion_r786475468



##########
File path: dev/source-release.sh
##########
@@ -38,7 +38,7 @@ usage () {
 # Default repository remote name
 remote="apache"

Review comment:
       In the PR that updated `-g`, the default remote repository was changed 
from `origin` to `apache`.
   
   I know many people use `apache` for their upstream project name.
   
   But, I believe we used `origin` for the remote name as this is possibly 
expected to run on ASF infra / github runners, where the origin repository is 
`origin`.
   
   If this runs on more than a PMCs laptop, then we should keep it as `origin` 
but add in the flag. This can be done in a follow up PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to