rdblue commented on a change in pull request #3823:
URL: https://github.com/apache/iceberg/pull/3823#discussion_r786957653
##########
File path: site/docs/flink.md
##########
@@ -290,18 +290,33 @@ USE iceberg_db;
```sql
CREATE TABLE `hive_catalog`.`default`.`sample` (
- id BIGINT COMMENT 'unique id',
+ id BIGINT PRIMARY KEY NOT ENFORCED COMMENT 'unique id',
data STRING
);
```
Table create commands support the most commonly used [flink create
clauses](https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/sql/create.html#create-table)
now, including:
+* `PRIMARY KEY NOT ENFORCED` to declare table primary key(s).
* `PARTITION BY (column1, column2, ...)` to configure partitioning, apache
flink does not yet support hidden partitioning.
* `COMMENT 'table document'` to set a table description.
* `WITH ('key'='value', ...)` to set [table configuration](./configuration.md)
which will be stored in apache iceberg table properties.
-Currently, it does not support computed column, primary key and watermark
definition etc.
+Currently, it does not support computed column and watermark definition etc.
Review comment:
We don't use words like "currently" or "yet" in documentation because
those easily get out of date. Instead, just state what support is currently.
These docs are going to be versioned soon, so it will remain correct in that
version of the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
