rdblue commented on a change in pull request #3742:
URL: https://github.com/apache/iceberg/pull/3742#discussion_r786997535
##########
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##########
@@ -180,43 +202,24 @@ ManifestGroup planWith(ExecutorService
newExecutorService) {
return CloseableIterable.transform(entries, e -> new BaseFileScanTask(
e.file().copy(), deleteFiles.forEntry(e), schemaString,
specString, residuals));
}
- });
-
- if (executorService != null) {
- return new ParallelIterable<>(tasks, executorService);
- } else {
- return CloseableIterable.concat(tasks);
- }
+ };
}
- /**
- * Returns an iterable for manifest entries in the set of manifests.
- * <p>
- * Entries are not copied and it is the caller's responsibility to make
defensive copies if
- * adding these entries to a collection.
- *
- * @return a CloseableIterable of manifest entries.
- */
public CloseableIterable<ManifestEntry<DataFile>> entries() {
return CloseableIterable.concat(entries((manifest, entries) -> entries));
}
- private <T> Iterable<CloseableIterable<T>> entries(
- BiFunction<ManifestFile, CloseableIterable<ManifestEntry<DataFile>>,
CloseableIterable<T>> entryFn) {
Review comment:
@yohengyang, please revert all of the whitespace and non-functional
changes. Otherwise, we can't really review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
