Zhangg7723 commented on a change in pull request #3919:
URL: https://github.com/apache/iceberg/pull/3919#discussion_r787644367
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -259,7 +259,7 @@ private void validateOptions() {
MIN_FILE_SIZE_BYTES, RewriteDataFiles.TARGET_FILE_SIZE_BYTES,
minFileSize, targetFileSize);
Preconditions.checkArgument(targetFileSize < maxFileSize,
- "Cannot set %s is greater than or equal to %s, all files written will
be larger than the threshold, %d >= %d",
Review comment:
If MAX_FILE_SIZE_BYTES equals to TARGET_FILE_SIZE_BYTES, argument check
still works and throws this exception. Anyway, there is a mistake I forget to
fix "%d >= %d" with parameters, I will reverse targetFileSize and maxFileSize
later.
thanks for your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
