aokolnychyi commented on a change in pull request #3949:
URL: https://github.com/apache/iceberg/pull/3949#discussion_r789954161
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java
##########
@@ -84,14 +85,14 @@ public static Distribution buildRequiredDistribution(Table
table, DistributionMo
public static Distribution buildCopyOnWriteDistribution(Table table, Command
command,
DistributionMode
distributionMode) {
- if (command == DELETE) {
- return buildCopyOnWriteDeleteDistribution(table, distributionMode);
+ if (command == DELETE || command == UPDATE) {
Review comment:
I thought about this and I think we can reuse the same distribution as
in DELETEs. A few edge cases is updating fields used in the partition spec and
sort order. I think the current logic would probably behave reasonably (see the
table below). Would appreciate any feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
