rdblue commented on a change in pull request #3954:
URL: https://github.com/apache/iceberg/pull/3954#discussion_r790313889
##########
File path: core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
##########
@@ -133,6 +133,11 @@ public BaseUpdatePartitionSpec addField(String name, Term
term) {
Pair<Integer, String> validationKey = Pair.of(sourceTransform.first(),
sourceTransform.second().toString());
PartitionField existing = transformToField.get(validationKey);
+ if (existing != null && deletes.contains(existing.fieldId()) &&
+
existing.transform().toString().equals(sourceTransform.second().toString())) {
Review comment:
Do we need to compare the `toString` representation? I thought
everything implemented `equals` correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
