rdblue commented on pull request #3691: URL: https://github.com/apache/iceberg/pull/3691#issuecomment-1019609414
Looks great. Thanks for updating this, @samredai! I'm going to go ahead and merge this. I think there's still an open question about what type to return from the `open` and `create` methods (and how to support `with`) but the overall structure looks great and we can solve that problem later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
