rdblue commented on a change in pull request #3834:
URL: https://github.com/apache/iceberg/pull/3834#discussion_r790357710
##########
File path: core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java
##########
@@ -163,9 +163,14 @@ public void delete(T row) throws IOException {
* @param key is the projected data whose columns are the same as the
equality fields.
*/
public void deleteKey(T key) throws IOException {
- internalPosDelete(asStructLike(key));
+ StructLike structLikeKey = asStructLike(key);
+ PathOffset previous = insertedRowMap.get(structLikeKey);
- eqDeleteWriter.write(key);
+ if (previous != null){
Review comment:
Style is incorrect here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
