pvary commented on pull request #3912:
URL: https://github.com/apache/iceberg/pull/3912#issuecomment-1020940450


   
   
   
   
   > > Could TestTables.createHiveTableSQL help here?
   > 
   > 
![image](https://user-images.githubusercontent.com/45056332/150929210-e73844bc-d955-4cf6-abab-978f8d43328d.png)
 @pvary TestTables.createHiveTableSQL can not set columns, but I need some hive 
columns to test. Could I continue to use sql?
   
   Good point. We might want to add a new method to the TestTables then, but if 
handling column types is too complicated, then at least create a local test 
method, so we do not duplicate the code.
   We might also want to test having column names matching nested field names 
too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to