CircArgs commented on pull request #3952: URL: https://github.com/apache/iceberg/pull/3952#issuecomment-1021223012
@rdblue I definitely agree with your comments. Overall, I feel like the state from the previous types PR into this one of having `Integer()` as the method to get a type is pretty ugly and unnecessary. This PR was meant as a stepping stone to something more akin to true generics. I'm thinking that a lot of the hangup for the true sort of generics was me having tried to mix literals in with types to consolidate them, so I've taken a big step backwards and removed all literal functionality while also slimming down the generics implementation. Please have a look at https://github.com/apache/iceberg/pull/3981 to compare -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
