jackye1995 commented on a change in pull request #3888:
URL: https://github.com/apache/iceberg/pull/3888#discussion_r791118861
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -244,21 +246,31 @@ private static String toTypeString(Type type) {
Set<String> addedNames = Sets.newHashSet();
for (NestedField field : metadata.schema().columns()) {
- addColumnWithDedupe(columns, addedNames, field);
+ addColumnWithDedupe(columns, addedNames, field, true);
Review comment:
nit: prefer inline comment for boolean argument `true /* is current */`
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -244,21 +246,31 @@ private static String toTypeString(Type type) {
Set<String> addedNames = Sets.newHashSet();
for (NestedField field : metadata.schema().columns()) {
- addColumnWithDedupe(columns, addedNames, field);
+ addColumnWithDedupe(columns, addedNames, field, true);
+ }
+
+ for (Schema schema : metadata.schemas()) {
+ if (schema.schemaId() != metadata.currentSchemaId()) {
+ for (NestedField field : schema.columns()) {
+ addColumnWithDedupe(columns, addedNames, field, false);
Review comment:
nit: same as above, inline comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
