rdblue commented on a change in pull request #3813:
URL: https://github.com/apache/iceberg/pull/3813#discussion_r791969876
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
##########
@@ -360,4 +403,26 @@ protected void finalize() throws Throwable {
LOG.warn("Unclosed output stream created by:\n\t{}", trace);
}
}
+
+ private static class FileAndDigest {
+ private final File file;
+ private final MessageDigest digest;
+
+ FileAndDigest(File file, MessageDigest digest) {
+ this.file = file;
+ this.digest = digest;
+ }
+
+ File file() {
+ return file;
+ }
+
+ byte[] getDigest() {
Review comment:
Iceberg doesn't use `get` because it isn't useful. We either omit it or
use a more specific verb. This should just be `digest` since it is a getter,
like `file`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
