aokolnychyi commented on a change in pull request #3984:
URL: https://github.com/apache/iceberg/pull/3984#discussion_r792168256



##########
File path: 
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java
##########
@@ -1441,6 +1441,132 @@ public void 
testRangePositionDeltaDeletePartitionedTable() {
         table, DELETE, expectedDistribution, 
SPEC_ID_PARTITION_FILE_POSITION_ORDERING);
   }
 
+  // 
===================================================================================
+  // Distribution and ordering for merge-on-read UPDATE operations with 
position deletes
+  // 
===================================================================================
+  //
+  // update mode is NOT SET -> CLUSTER BY _spec_id, _partition + LOCALLY ORDER 
BY _spec_id, _partition, _file, _pos

Review comment:
       Same like in merge-on-read DELETE. Here we are dealing with full rows so 
it does not seem like a good idea to group everything into a single task for 
unpartitioned tables. Ideas are welcome.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to