rdblue commented on a change in pull request #3933:
URL: https://github.com/apache/iceberg/pull/3933#discussion_r792232443
##########
File path:
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java
##########
@@ -819,6 +842,27 @@ public void
testPartitionedImportFromEmptyPartitionDoesNotThrow() {
RowFactory.create(4, "Will Doe", "facilities",
toDate("2021-01-02"))),
new StructType(dateStruct)).repartition(2);
+ private static final StructField[] timeStampstruct = {
+ new StructField("id", DataTypes.IntegerType, true, Metadata.empty()),
+ new StructField("name", DataTypes.StringType, true, Metadata.empty()),
+ new StructField("dept", DataTypes.StringType, true, Metadata.empty()),
+ new StructField("ts", DataTypes.TimestampType, true, Metadata.empty())
+ };
+
+ private static Timestamp toTimestamp(String value) {
Review comment:
Okay, I see. I was wrong before. This is actually producing a Timestamp
because that's what Spark's public row API uses. Instead, could you use
SparkSQL and literal values to avoid doing this conversion manually? I think
that will make for a much more reliable test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
