pvary commented on a change in pull request #3980:
URL: https://github.com/apache/iceberg/pull/3980#discussion_r792414700
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -293,8 +296,10 @@ public void testJoinTablesSupportedTypes() throws
IOException {
public void testSelectDistinctFromTable() throws IOException {
for (int i = 0; i < SUPPORTED_TYPES.size(); i++) {
Type type = SUPPORTED_TYPES.get(i);
- if (type == Types.TimestampType.withZone() && isVectorized) {
- // ORC/TIMESTAMP_INSTANT is not a supported vectorized type for Hive
+ if (isUnsupportedOrcVectorizedTypeForHive(type)) {
Review comment:
I think this is a bit awkward. Wouldn't be better if we just create a
single method, like:
`private static boolean vectorizationSupported(FileFormat fileFormat, Type
type)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
