RussellSpitzer commented on a change in pull request #3973:
URL: https://github.com/apache/iceberg/pull/3973#discussion_r792751801



##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java
##########
@@ -60,7 +60,8 @@
       ProcedureParameter.required("table", DataTypes.StringType),
       ProcedureParameter.required("source_table", DataTypes.StringType),
       ProcedureParameter.optional("partition_filter", STRING_MAP),
-      ProcedureParameter.optional("check_duplicate_files", 
DataTypes.BooleanType)
+      ProcedureParameter.optional("check_duplicate_files", 
DataTypes.BooleanType),
+      ProcedureParameter.optional("list_partition_parallelism", 
DataTypes.IntegerType)

Review comment:
       on ExpireSnapshots and RemoveOrphans we have the parallelism parameter 
named
   
   max_concurrent_xxxxxx
   
   So maybe we just keep that convention? "max_concurrent_reads"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to