jackye1995 commented on a change in pull request #3983:
URL: https://github.com/apache/iceberg/pull/3983#discussion_r792967759
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -113,6 +113,15 @@ default RewriteDataFiles sort(SortOrder sortOrder) {
throw new UnsupportedOperationException("SORT Rewrite Strategy not
implemented for this framework");
}
+ /**
+ * Choose Z-ORDER as a strategy for this rewrite operation with a specified
list of columns to use
+ * @param columns Columns to be used to generate Z-Values
+ * @return this for method chaining
+ */
+ default RewriteDataFiles zOrder(String... columns) {
Review comment:
> in a follow up version we take some basic statistics from the data set
and use that to develop our z ordering
do you have any current thoughts about how this would be determined by
statistics? I always imagined some human decision is still needed to tune the
tradeoffs among different configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
