pvary commented on a change in pull request #3912:
URL: https://github.com/apache/iceberg/pull/3912#discussion_r793701901
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java
##########
@@ -110,10 +165,13 @@ public static Schema convert(List<String> names,
List<TypeInfo> types, List<Stri
* @param autoConvert If <code>true</code> then TINYINT and SMALLINT is
converted to INTEGER and VARCHAR and CHAR is
* converted to STRING. Otherwise if these types are used
in the Hive schema then exception is
* thrown.
+ * @param identifierFieldNames The identifierFieldSet which corresponds to
identifierFieldIdSet.
Review comment:
The names of the identifier fields for the schema
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java
##########
@@ -63,9 +78,10 @@ public static Schema convert(List<FieldSchema> fieldSchemas)
{
* @param autoConvert If <code>true</code> then TINYINT and SMALLINT is
converted to INTEGER and VARCHAR and CHAR is
* converted to STRING. Otherwise if these types are used
in the Hive schema then exception is
* thrown.
+ * @param identifierFieldNames The identifierFieldSet which corresponds to
identifierFieldIdSet.
Review comment:
nit: Maybe: `The names of the identifier fields for the schema`
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java
##########
@@ -54,7 +58,18 @@ private HiveSchemaUtil() {
* @return An equivalent Iceberg Schema
*/
public static Schema convert(List<FieldSchema> fieldSchemas) {
- return convert(fieldSchemas, false);
+ return convert(fieldSchemas, false, Collections.emptySet());
+ }
+
+ /**
+ * Converts a Hive schema (list of FieldSchema objects) to an Iceberg
schema. If some of the types are not convertible
+ * then exception is thrown.
+ * @param fieldSchemas The list of the columns.
+ * @param identifierFieldNames The identifierFieldSet which corresponds to
identifierFieldIdSet.
Review comment:
nit: Maybe: `The names of the identifier fields for the schema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
