rdblue commented on a change in pull request #3989:
URL: https://github.com/apache/iceberg/pull/3989#discussion_r793973916



##########
File path: python_legacy/iceberg/api/types/types.py
##########
@@ -696,6 +696,12 @@ def key_id(self):
     def value_id(self):
         return self.value_field.field_id
 
+    def asMapType(self):

Review comment:
       It looks like these are being converted to snake_case instead. Should 
this be converted as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to