rdblue commented on pull request #19:
URL: https://github.com/apache/iceberg-docs/pull/19#issuecomment-1023631703
On the termynal example, I think there are a couple things we can do to
improve it. For example, we could first do
`spark.read.load("nyc.taxis").count()` and show like 2,000,000 or something.
Then we could do `spark.read.option("as-of-timestamp", 1526266800000).count()`
and show a lower number. I think that's good to show that the data is changing,
rather than relying on variable names. And I also think my earlier suggestion
to use `System.currentTimeMillis() - ONE_DAY_MS` is a bad idea because it makes
the code look way too long and complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
