kbendick commented on a change in pull request #3986:
URL: https://github.com/apache/iceberg/pull/3986#discussion_r794116120
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkManifestUtil.java
##########
@@ -62,9 +62,10 @@ static ManifestFile writeDataFiles(OutputFile outputFile,
PartitionSpec spec, Li
}
static ManifestOutputFileFactory createOutputFileFactory(Table table, String
flinkJobId, int subTaskId,
- long attemptNumber)
{
+ String
operatorUniqueId, long attemptNumber) {
TableOperations ops = ((HasTableOperations) table).operations();
- return new ManifestOutputFileFactory(ops, table.io(), table.properties(),
flinkJobId, subTaskId, attemptNumber);
+ return new ManifestOutputFileFactory(ops, table.io(), table.properties(),
flinkJobId, subTaskId,
+ operatorUniqueId, attemptNumber);
Review comment:
Nit: Can we fit all of the arguments on one line if they're placed on
the next line?
```java
return new ManifestOutputFileFactory(
ops, table.io(), table.properties(), flinkJobId, subTaskId,
operatorUniqueId, attemptNumber);
```
You could also make the new parameter into `operatorUid` (or `operatorId`)
to shorten it.
Not a blocker by any means but would be nice if possible. =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
