aokolnychyi commented on a change in pull request #2925:
URL: https://github.com/apache/iceberg/pull/2925#discussion_r794179769
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -225,6 +225,9 @@ private TableProperties() {
public static final String MIN_SNAPSHOTS_TO_KEEP =
"history.expire.min-snapshots-to-keep";
public static final int MIN_SNAPSHOTS_TO_KEEP_DEFAULT = 1;
+ public static final String DYNAMIC_OVERWRITE_ISOLATION_LEVEL =
"write.dynamic.overwrite.isolation-level";
Review comment:
Are we sure we want to have a table property for this? Also, does this
mean it will be a breaking change in the behavior given the currently proposed
default?
I am not sure what's best yet but we can express the same things via data
source options. If we want to add a table property for this, then we have to
handle other query engines too (does Flink use this API?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
