smaspe commented on issue #3607:
URL: https://github.com/apache/iceberg/issues/3607#issuecomment-1024244353


   Hi @RussellSpitzer , sorry to jump on this thread, but I have a question 
regarding your last message, if you could elaborate, as I think I'm missing a 
step:
   
   > For example if you say  `purchase_ts = timestampOf(2021-01-01)` and you 
have actually partitioning on `day(purchase_ts)` it transforms the predicate 
into `day(purchase_ts) = day(timestampOf(2021-01-01)`.
   
   Surely, `purchase_ts` being a timestamp, has all sorts of values that are 
not a round day, so to have a predicate transformed into `day(purchase_ts) = 
day(timestampOf(2021-01-01)`, how would you write it?
   
   - `on target.purchase_ts = timestampOf(2021-01-01)` doesn't seem right, 
because if `purchase_ts = 2021-01-01 14:10:00.001`, the meaning is actually 
different
   - `on target.purchase_ts = timestamp '2021-01-01 14:10:00.001'`, if you know 
the exact value of the partition key in the target row
   - `on target.purchase_ts >= timestamp '2021-01-01' and target.purchase_ts < 
timestamp '2021-01-02'`
   - I don't think `on day(target.purchase_ts) = '2021-01-01'` or similar 
works, as far as I've tried?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to