rdblue commented on a change in pull request #3999:
URL: https://github.com/apache/iceberg/pull/3999#discussion_r794833581
##########
File path: dev/source-release.sh
##########
@@ -113,8 +113,8 @@ git archive $release_hash --worktree-attributes --prefix
$tag/ -o $projectdir/$t
echo "Signing the tarball..."
[[ -z "$keyid" ]] && keyopt="-u $keyid"
-gpg --detach-sig $keyopt --armor --output ${projectdir}/${tarball}.asc
${projectdir}/$tarball
-shasum -a 512 ${projectdir}/$tarball > ${projectdir}/${tarball}.sha512
+gpg $keyopt --armor --output ${projectdir}/${tarball}.asc --detach-sig
${projectdir}/$tarball
+shasum -a 512 $tarball > ${projectdir}/${tarball}.sha512
Review comment:
I think it's fine to run in the project root directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
