rdblue commented on a change in pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#discussion_r794838456
##########
File path: python/src/iceberg/types.py
##########
@@ -46,6 +46,9 @@ def __repr__(self):
def __str__(self):
return self._type_string
+ def __eq__(self, other):
Review comment:
Yes, these should be immutable. Is it possible to make them singletons,
maybe by hijacking `__new__`? I'm not sure what is normal here. @CircArgs may
have an idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
