SinghAsDev commented on pull request #3774: URL: https://github.com/apache/iceberg/pull/3774#issuecomment-1025235542
> @SinghAsDev, I did another round of review. This also still needs to update [Iceberg generics](https://github.com/apache/iceberg/blob/master/parquet/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java), I think. Thanks for thorough reviews @rdblue ! I thought I already covered the Iceberg generic with this [change](https://github.com/apache/iceberg/pull/3774/files#diff-b8e8443fcec3843e538dbc702d4c131ff58359cb83ccdb211d8679c1d77c16bd). Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
