marton-bod commented on pull request #4018: URL: https://github.com/apache/iceberg/pull/4018#issuecomment-1027976504
@SinghAsDev Thanks for your answer, I think you're raising a valid point here. As I see it, there are two separate issues: - When creating external tables using the Hive engine, Hive appends `external.table.purge=true` to the table properties behind the scenes in `HiveIcebergMetaHook`. This goes against user expectations even in Hive 4.0+. I'll prepare a PR to fix that up on the Hive engine side (which should fix your Hive test failures presumably). - On the HiveCatalog-level, how do we want to handle different combinations of external/managed tables with the gc.enabled flag. I think it makes sense to disallow the MANAGED + `gc.enabled=false` combination. But I would not disallow the EXTERNAL + `gc.enabled=true` combination, exactly because Hive 4.0 makes this combination valid via the `external.table.purge=true` flag Please let me know what you think, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
