rdblue commented on a change in pull request #4024:
URL: https://github.com/apache/iceberg/pull/4024#discussion_r797816930
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTable.java
##########
@@ -40,8 +40,12 @@
import org.junit.Test;
public class TestCreateTable extends SparkCatalogTestBase {
+
+ private final boolean isHadoopCatalog;
+
public TestCreateTable(String catalogName, String implementation,
Map<String, String> config) {
super(catalogName, implementation, config);
+ this.isHadoopCatalog = "testhadoop".equals(catalogName);
Review comment:
There's no need for a field. Can you just move this test into the
`Assume` line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
