rdblue commented on a change in pull request #3984:
URL: https://github.com/apache/iceberg/pull/3984#discussion_r798766661
##########
File path: core/src/main/java/org/apache/iceberg/io/PositionDeltaWriter.java
##########
@@ -41,6 +41,21 @@
*/
void insert(T row, PartitionSpec spec, StructLike partition);
+ /**
+ * Inserts a new version of an existing row to the provided spec/partition.
+ * <p>
+ * This method allows writers to distinguish new and updated records. The
caller must separately
+ * invoke {@link #delete(CharSequence, long, PartitionSpec, StructLike)} for
the original
+ * row position that is being updated.
+ *
+ * @param row a new version of an existing row
+ * @param spec a new partition spec
+ * @param partition a new partition or null if the spec is unpartitioned
+ */
+ default void update(T row, PartitionSpec spec, StructLike partition) {
Review comment:
I see. The partitioned writer has a comment about this. Updates come in
so that deletes are clustered and ordered correctly -- by the path and position
that will be deleted. But updates may have caused the row to change partitions
and so that clustering for deletes may not match clustering for updates. So we
do need to use a separate fanout writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
