RussellSpitzer commented on pull request #2496: URL: https://github.com/apache/iceberg/pull/2496#issuecomment-1029413929
> @RussellSpitzer are you referring to [this](https://github.com/apache/iceberg/pull/2496/files#diff-712079321f18196c99853a45468cd71c27d6e38d12516b4fd1489fd31154f818) or something else? I think the behaviors need to be elaborated a bit more than that and we also need information in JSON Serialzation (Appendix C) For example, does a writer upon rewriting a file with a default value set, materialize that value? If the default for a column is changed do we change the value? I think "manifested" needs explanation as well. If defaults are used on writers I think we probably need to explain that in the writer section. So to list all of the things. A field is required and has a default value, What does this mean on writing/rewriting + reading. What happens if this default is changed in the schema but the column id remains the same. A field is optional and has a default value, What does this mean on writing/rewriting + reading. What happens if this default is changed ... Can a default valued field be applied to files where the column ID of the field is not present? I believe this is part of the idea here but i'm not sure how it would be defined. Is the idea that if the column ID is not present in a given data file do we always just return the default of the current schema? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
