aokolnychyi commented on a change in pull request #3984:
URL: https://github.com/apache/iceberg/pull/3984#discussion_r799864319
##########
File path:
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java
##########
@@ -79,13 +79,16 @@ public void setupTable() throws Exception {
public void testPositionDeltaInsertOnly() throws IOException {
FileWriterFactory<T> writerFactory = newWriterFactory(table.schema());
- ClusteredDataWriter<T> dataWriter = new ClusteredDataWriter<>(
+ ClusteredDataWriter<T> insertWriter = new ClusteredDataWriter<>(
+ writerFactory, fileFactory, table.io(),
+ fileFormat, TARGET_FILE_SIZE);
Review comment:
Wrapped for the consistency with the rest of the code around.
##########
File path:
data/src/test/java/org/apache/iceberg/io/TestPositionDeltaWriters.java
##########
@@ -144,13 +147,16 @@ public void testPositionDeltaDeleteOnly() throws
IOException {
PartitionSpec unpartitionedSpec = table.specs().get(0);
PartitionSpec partitionedSpec = table.specs().get(1);
- ClusteredDataWriter<T> dataWriter = new ClusteredDataWriter<>(
+ ClusteredDataWriter<T> insertWriter = new ClusteredDataWriter<>(
+ writerFactory, fileFactory, table.io(),
+ fileFormat, TARGET_FILE_SIZE);
Review comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
