jun-he commented on a change in pull request #4041:
URL: https://github.com/apache/iceberg/pull/4041#discussion_r800117197
##########
File path: python_legacy/iceberg/hive/hive_tables.py
##########
@@ -67,9 +69,11 @@ def new_table_ops(self, conf, database, table):
def get_client(self) -> HMSClient:
from urllib.parse import urlparse
+ iprot = self.conf.get(HiveTables.IPROT)
Review comment:
Do we need to put a default value? Will it still work if iprot and oprot
are None value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
