stevenzwu commented on a change in pull request #3181:
URL: https://github.com/apache/iceberg/pull/3181#discussion_r800330001
##########
File path: parquet/src/test/java/org/apache/iceberg/parquet/TestParquet.java
##########
@@ -97,15 +118,14 @@ public void testNumberOfBytesWritten() throws IOException {
Assert.assertEquals(expectedSize, actualSize);
}
- private Pair<File, Long> generateFileWithTwoRowGroups(Function<MessageType,
ParquetValueWriter<?>> createWriterFunc)
+ private Pair<File, Long> generateFileWithTwoRowGroups(
Review comment:
Updated the method to build the props inside this method.
`desiredRecordCount` is already part of the method signature. No more
hardcoded 1 more than the row group size in records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
