samredai commented on a change in pull request #4021:
URL: https://github.com/apache/iceberg/pull/4021#discussion_r800945448
##########
File path: python/tox.ini
##########
@@ -16,7 +16,7 @@
# under the License.
[tox]
-envlist = py37,py38,py39,linters
+envlist = py38,py39,linters
Review comment:
I agree, but Protocol was added in 3.8. If we're really aiming to use
this for documentation purposes only and don't actually need the functionality
of structural subtyping, I can change these to normal classes and include
"These are Protocols for documentation purposes only" in the docstrings. How
does that sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
