kbendick commented on a change in pull request #4039:
URL: https://github.com/apache/iceberg/pull/4039#discussion_r801180894
##########
File path: rest_docs/rest-catalog-open-api.yaml
##########
@@ -1381,15 +1381,35 @@ components:
} }
CreateNamespaceResponse:
- description: A succesful call to create a namespace
+ description:
+ Represents a successful call to create a namespace.
+ Returns the namespace created, as well as any properties that were
stored for the namespace,
+ including those the server might have added. Implemenations are not
required to support namespace
+ properties.
content:
application/json:
schema:
type: object
+ required:
+ - namespace
properties:
- created:
- type: boolean
- description: true if the namespace was added to the catalog
+ namespace:
+ $ref: '#/components/schemas/Namespace'
+ properties:
+ type: object
+ additionalProperties:
+ type: string
+ description:
+ Properties stored on the namespace, if supported by the
server.
+ If the server does not support namespace properties, it
should return null for this field.
Review comment:
Yeah I'm actually rethinking that. This seems like an arbitrary
requirement.
Originally my thinking was to see if the server supported it or not, but
that can really be an implementation detail and left up to them.
In the PR for adding serializers, explicit `null` and omitting the property
are both fine and parse correctly. The final object winds up with an empty map
if calling the getter method on it.
**TLDR** I removed these lines entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
