rdblue commented on a change in pull request #4060:
URL: https://github.com/apache/iceberg/pull/4060#discussion_r801826230
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/DataIterator.java
##########
@@ -62,18 +96,25 @@ public boolean hasNext() {
@Override
public T next() {
updateCurrentIterator();
+ recordOffset += 1;
return currentIterator.next();
}
+ public boolean isCurrentFileDone() {
Review comment:
I think there's probably a better name for this, like
`currentFileHasNext` that fits better with the `Iterator` naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
