rdblue commented on a change in pull request #4009:
URL: https://github.com/apache/iceberg/pull/4009#discussion_r801843698



##########
File path: .github/workflows/flink-ci.yml
##########
@@ -73,7 +73,7 @@ jobs:
         key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
         restore-keys: ${{ runner.os }}-gradle
     - run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | 
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
-    - run: ./gradlew -DsparkVersions= -DhiveVersions= -DflinkVersions=${{ 
matrix.flink }} :iceberg-flink:iceberg-flink-${{ matrix.flink }}:check 
:iceberg-flink:iceberg-flink-runtime-${{ matrix.flink }}:check -Pquick=true -x 
javadoc
+    - run: ./gradlew -DsparkVersions= -DscalaVersion= -DhiveVersions= 
-DflinkVersions=${{ matrix.flink }} :iceberg-flink:iceberg-flink-${{ 
matrix.flink }}:check :iceberg-flink:iceberg-flink-runtime-${{ matrix.flink 
}}:check -Pquick=true -x javadoc

Review comment:
       Is this change needed? If there are no Spark versions, then it should be 
a noop to set the Scala version to nothing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to