szehon-ho commented on a change in pull request #4050:
URL: https://github.com/apache/iceberg/pull/4050#discussion_r802955922
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -51,6 +58,7 @@
* All fields are initialized by calling {@link S3FileIO#initialize(Map)}
later.
*/
public S3FileIO() {
+ metrics = FileIOMetrics.nullMetrics();
Review comment:
Optional style, could we initialize this in the variable declaration ,
to save having to look through multiple constructors for the value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
