zinking commented on a change in pull request #2642:
URL: https://github.com/apache/iceberg/pull/2642#discussion_r803269617
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -259,17 +271,31 @@ private WriteBuilder
createContextFunc(Function<Map<String, String>, Context> ne
conf.set(entry.getKey(), entry.getValue());
}
- ParquetProperties parquetProperties = ParquetProperties.builder()
+ ParquetProperties.Builder propsBuilder = ParquetProperties.builder()
.withWriterVersion(writerVersion)
.withPageSize(pageSize)
.withDictionaryPageSize(dictionaryPageSize)
- .build();
+ .withMaxBloomFilterBytes(bloomFilterMaxBytes)
+ .withBloomFilterEnabled(bloomFilterEnabled);
+
+ new ColumnConfigParser()
Review comment:
I know it's probably not a big deal, but I mean could new instances be
avoided ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
