rdblue commented on a change in pull request #4083:
URL: https://github.com/apache/iceberg/pull/4083#discussion_r804262033
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -217,17 +211,44 @@ static Context deleteContext(Map<String, String> config) {
Context dataContext = dataContext(config);
String codecAsString = config.get(DELETE_AVRO_COMPRESSION);
- CodecFactory codec = codecAsString != null ? toCodec(codecAsString) :
dataContext.codec();
+ String compressionLevel =
config.getOrDefault(DELETE_AVRO_COMPRESSION_LEVEL,
AVRO_COMPRESSION_LEVEL_DEFAULT);
+ CodecFactory codec = codecAsString != null ? toCodec(codecAsString,
compressionLevel) : dataContext.codec();
return new Context(codec);
}
- private static CodecFactory toCodec(String codecAsString) {
+ private static CodecFactory toCodec(String codecAsString, String
compressionLevel) {
+ CodecFactory codecFactory = null;
try {
- return
CodecName.valueOf(codecAsString.toUpperCase(Locale.ENGLISH)).get();
+ switch (Codec.valueOf(codecAsString.toUpperCase(Locale.ENGLISH))) {
+ case UNCOMPRESSED:
+ codecFactory = CodecFactory.nullCodec();
+ break;
+ case SNAPPY:
+ codecFactory = CodecFactory.snappyCodec();
+ break;
+ case ZSTD:
+ codecFactory =
CodecFactory.zstandardCodec(getCompressionLevel(compressionLevel,
+ ZSTD_COMPRESSION_LEVEL_DEFAULT));
Review comment:
We try to make line breaks at the most useful place for readability.
This is a bit odd because it's nested 2 levels. Instead, I think it would be
better to add the line break so that the `compressionLevel` call is on a single
line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
