stevenzwu commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r804827121
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -168,6 +170,11 @@ public Builder table(Table newTable) {
return this;
}
+ public Builder properties(Map<String, String> newProps) {
Review comment:
May I suggest the following? I don't think we need to add trivial
`@param` and `@return`
```
/**
* Set the write properties for Flink sink. Write properties (with the
same keys) defined in table properties
* will be overwritten by properties provided here.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
