rdblue commented on a change in pull request #2496:
URL: https://github.com/apache/iceberg/pull/2496#discussion_r804918709



##########
File path: site/docs/spec.md
##########
@@ -159,6 +161,13 @@ A **`list`** is a collection of values with some element 
type. The element field
 
 A **`map`** is a collection of key-value pairs with a key type and a value 
type. Both the key field and value field each have an integer id that is unique 
in the table schema. Map keys are required and map values can be either 
optional or required. Both map keys and map values may be any type, including 
nested types.
 
+Iceberg supports default-value semantics for fields of nested types (i.e., 
struct, list and map). Specifically, a field 
+of a nested type field can have a default value that will be returned upon 
reading this field, if it is not manifested. 

Review comment:
       What does "manifested" mean? I believe that we want default values to be 
filled in if the column does not exist in a data file. If the column does exist 
in a data file and is null, then the written value is null and Iceberg should 
return null.

##########
File path: site/docs/spec.md
##########
@@ -151,6 +151,8 @@ A table's **schema** is a list of named columns. All data 
types are either primi
 
 For the representations of these types in Avro, ORC, and Parquet file formats, 
see Appendix A.
 
+Default values for fields are supported, see Neted Types below.

Review comment:
       Typo: "Neted" should be "Nested"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to