jackye1995 commented on a change in pull request #4099:
URL: https://github.com/apache/iceberg/pull/4099#discussion_r805062939
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -431,6 +433,34 @@ protected boolean isValidIdentifier(TableIdentifier
tableIdentifier) {
IcebergToGlueConverter.isValidTableName(tableIdentifier.name());
}
+ @Override
+ public org.apache.iceberg.Table registerTable(TableIdentifier identifier,
String metadataFileLocation) {
+ Preconditions.checkArgument(isValidIdentifier(identifier),
Review comment:
these can likely be generalized to the base metastore class, will do
that after we have some other implementations to see how much common code we
can extract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
